Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/generated/snippets): remove orphaned snippets #6541

Merged
merged 2 commits into from Aug 19, 2022

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Aug 18, 2022

  • upgrade dependencies

@quartzmo quartzmo requested a review from a team as a code owner August 18, 2022 21:14
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 18, 2022
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but most if not all of these should have replace directives that override what code is actually being run. This is how we can have samples for unreleased code.

@quartzmo
Copy link
Member Author

most if not all of these should have replace directives that override what code is actually being run

Right, my main objective with this PR is to see if the kokoro build errors we saw yesterday in #6523 occur in a new branch off main.

@quartzmo
Copy link
Member Author

Even though the build passes, I still see the errors below in the kokoro latest log:

@codyoss Does this suggest that there are orphaned snippet files (such as CreateSnapshotSchedulePolicy/main.go) that need to be cleaned up?

# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/CreateSnapshotSchedulePolicy
baremetalsolution/apiv2/Client/CreateSnapshotSchedulePolicy/main.go:36:30: undefined: baremetalsolution.CreateSnapshotSchedulePolicyRequest
baremetalsolution/apiv2/Client/CreateSnapshotSchedulePolicy/main.go:40:17: c.CreateSnapshotSchedulePolicy undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method CreateSnapshotSchedulePolicy)
# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/CreateVolumeSnapshot
baremetalsolution/apiv2/Client/CreateVolumeSnapshot/main.go:36:30: undefined: baremetalsolution.CreateVolumeSnapshotRequest
baremetalsolution/apiv2/Client/CreateVolumeSnapshot/main.go:40:17: c.CreateVolumeSnapshot undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method CreateVolumeSnapshot)
# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/DeleteSnapshotSchedulePolicy
baremetalsolution/apiv2/Client/DeleteSnapshotSchedulePolicy/main.go:36:30: undefined: baremetalsolution.DeleteSnapshotSchedulePolicyRequest
baremetalsolution/apiv2/Client/DeleteSnapshotSchedulePolicy/main.go:40:10: c.DeleteSnapshotSchedulePolicy undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method DeleteSnapshotSchedulePolicy)
# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/DeleteVolumeSnapshot
baremetalsolution/apiv2/Client/DeleteVolumeSnapshot/main.go:36:30: undefined: baremetalsolution.DeleteVolumeSnapshotRequest
baremetalsolution/apiv2/Client/DeleteVolumeSnapshot/main.go:40:10: c.DeleteVolumeSnapshot undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method DeleteVolumeSnapshot)
# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/GetSnapshotSchedulePolicy
baremetalsolution/apiv2/Client/GetSnapshotSchedulePolicy/main.go:36:30: undefined: baremetalsolution.GetSnapshotSchedulePolicyRequest
baremetalsolution/apiv2/Client/GetSnapshotSchedulePolicy/main.go:40:17: c.GetSnapshotSchedulePolicy undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method GetSnapshotSchedulePolicy)
# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/GetVolumeSnapshot
baremetalsolution/apiv2/Client/GetVolumeSnapshot/main.go:36:30: undefined: baremetalsolution.GetVolumeSnapshotRequest
baremetalsolution/apiv2/Client/GetVolumeSnapshot/main.go:40:17: c.GetVolumeSnapshot undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method GetVolumeSnapshot)
# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/ListSnapshotSchedulePolicies
baremetalsolution/apiv2/Client/ListSnapshotSchedulePolicies/main.go:37:30: undefined: baremetalsolution.ListSnapshotSchedulePoliciesRequest
baremetalsolution/apiv2/Client/ListSnapshotSchedulePolicies/main.go:41:10: c.ListSnapshotSchedulePolicies undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method ListSnapshotSchedulePolicies)
# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/ListVolumeSnapshots
baremetalsolution/apiv2/Client/ListVolumeSnapshots/main.go:37:30: undefined: baremetalsolution.ListVolumeSnapshotsRequest
baremetalsolution/apiv2/Client/ListVolumeSnapshots/main.go:41:10: c.ListVolumeSnapshots undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method ListVolumeSnapshots)
# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/RestoreVolumeSnapshot
baremetalsolution/apiv2/Client/RestoreVolumeSnapshot/main.go:36:30: undefined: baremetalsolution.RestoreVolumeSnapshotRequest
baremetalsolution/apiv2/Client/RestoreVolumeSnapshot/main.go:40:15: c.RestoreVolumeSnapshot undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method RestoreVolumeSnapshot)
# cloud.google.com/go/internal/generated/baremetalsolution/apiv2/Client/UpdateSnapshotSchedulePolicy
baremetalsolution/apiv2/Client/UpdateSnapshotSchedulePolicy/main.go:36:30: undefined: baremetalsolution.UpdateSnapshotSchedulePolicyRequest
baremetalsolution/apiv2/Client/UpdateSnapshotSchedulePolicy/main.go:40:17: c.UpdateSnapshotSchedulePolicy undefined (type *"cloud.google.com/go/baremetalsolution/apiv2".Client has no field or method UpdateSnapshotSchedulePolicy)
# cloud.google.com/go/internal/generated/contactcenterinsights/apiv1/Client/CancelOperation
contactcenterinsights/apiv1/Client/CancelOperation/main.go:40:10: c.CancelOperation undefined (type *"cloud.google.com/go/contactcenterinsights/apiv1".Client has no field or method CancelOperation)
# cloud.google.com/go/internal/generated/contactcenterinsights/apiv1/Client/GetOperation
contactcenterinsights/apiv1/Client/GetOperation/main.go:40:17: c.GetOperation undefined (type *"cloud.google.com/go/contactcenterinsights/apiv1".Client has no field or method GetOperation)
# cloud.google.com/go/internal/generated/contactcenterinsights/apiv1/Client/ListOperations
contactcenterinsights/apiv1/Client/ListOperations/main.go:41:10: c.ListOperations undefined (type *"cloud.google.com/go/contactcenterinsights/apiv1".Client has no field or method ListOperations)
# cloud.google.com/go/internal/generated/servicemanagement/apiv1/ServiceManagerClient/DisableService
servicemanagement/apiv1/ServiceManagerClient/DisableService/main.go:36:30: undefined: servicemanagement.DisableServiceRequest
servicemanagement/apiv1/ServiceManagerClient/DisableService/main.go:40:15: c.DisableService undefined (type *"cloud.google.com/go/servicemanagement/apiv1".ServiceManagerClient has no field or method DisableService)
# cloud.google.com/go/internal/generated/servicemanagement/apiv1/ServiceManagerClient/EnableService
servicemanagement/apiv1/ServiceManagerClient/EnableService/main.go:36:30: undefined: servicemanagement.EnableServiceRequest
servicemanagement/apiv1/ServiceManagerClient/EnableService/main.go:40:15: c.EnableService undefined (type *"cloud.google.com/go/servicemanagement/apiv1".ServiceManagerClient has no field or method EnableService)

@codyoss
Copy link
Member

codyoss commented Aug 19, 2022

@quartzmo Yeah lets just get those cleaned up here to. From prior breaking changes that have removed things. snipetgen is only additive today, it will not remove orphaned snippets. This may be a good enhancement for the future.

@quartzmo
Copy link
Member Author

/cc @noahdietz

snipetgen is only additive today, it will not remove orphaned snippets. This may be a good enhancement for the future.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Aug 19, 2022
@snippet-bot
Copy link

snippet-bot bot commented Aug 19, 2022

Here is the summary of changes.

You are about to delete 26 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@quartzmo quartzmo merged commit d2f33ab into googleapis:main Aug 19, 2022
@quartzmo quartzmo deleted the snippets-deps branch August 19, 2022 19:11
@quartzmo quartzmo changed the title chore(internal/generated/snippets): upgrade dependencies chore(internal/generated/snippets): remove orphaned snippets Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants