Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bttest): Reject empty regex row filters #6520

Merged
merged 3 commits into from Oct 24, 2022

Conversation

adamroyjones
Copy link
Contributor

This fixes GitHub issue #6519; see that issue for further commentary.

@google-cla
Copy link

google-cla bot commented Aug 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 16, 2022
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Sep 16, 2022
@telpirion telpirion added automerge Merge the pull request once unit tests and other checks pass. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 16, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 16, 2022
@adamroyjones
Copy link
Contributor Author

I've now rebased the branch onto the current version of main.

I don't know how the CI system is set up in this repo. Is the "kokoro" step causing it to block?

This fixes GitHub issue googleapis#6519; see that issue for further commentary.
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Oct 16, 2022
@telpirion
Copy link
Contributor

I've now rebased the branch onto the current version of main.

I don't know how the CI system is set up in this repo. Is the "kokoro" step causing it to block?

Yeah, the CI can cause it to block. I'll try to get this PR unstuck.

@telpirion telpirion enabled auto-merge (squash) October 24, 2022 21:14
@telpirion telpirion added the automerge Merge the pull request once unit tests and other checks pass. label Oct 24, 2022
@telpirion telpirion merged commit 68caf4b into googleapis:main Oct 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 24, 2022
@adamroyjones adamroyjones deleted the reject-invalid-regex branch October 24, 2022 23:06
kimihrr pushed a commit to kimihrr/google-cloud-go-kimia that referenced this pull request Oct 25, 2022
This fixes GitHub issue googleapis#6519; see that issue for further commentary.

Co-authored-by: Eric Schmidt <erschmid@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants