Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery/storage/managedwriter): propagate calloptions to append #6488

Merged
merged 5 commits into from Aug 10, 2022

Conversation

shollyman
Copy link
Contributor

Reporter identified that we're not properly propagating user-specified
call options when we open the AppendRows bidi stream.

Fixes: #6487

Reporter identified that we're not properly propagating user-specified
call options when we open the AppendRows bidi stream.

Fixes: googleapis#6487
@shollyman shollyman requested a review from a team August 9, 2022 05:29
@shollyman shollyman requested a review from a team as a code owner August 9, 2022 05:29
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the BigQuery API. labels Aug 9, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Aug 9, 2022
@shollyman shollyman requested review from quartzmo and removed request for Neenu1995 August 9, 2022 21:27
@shollyman shollyman enabled auto-merge (squash) August 9, 2022 22:01
@shollyman
Copy link
Contributor Author

The actual fix here is to pass the variadic opts... when streamFunc is invoked after attaching metadata. The rest of the changes in this PR are to make it testable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.
Projects
None yet
2 participants