Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(compute): wait on operations and don't retry them #6292

Merged
merged 3 commits into from Jun 30, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jun 30, 2022

Operations should be waited on and not just created. This was causing
tests to fail because the operation was finishing silently and then
subsquent delete operations could not find the resulting instance
that had already been deleted.

Fixes: #5988

Operations should be waited on and not just created. This was causing
tests to fail because the operation was finishing silently and then
subsquent delete operations could not find the resulting instance
that had already been deleted.

Fixes: googleapis#5988
@codyoss codyoss requested a review from a team as a code owner June 30, 2022 19:52
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: compute Issues related to the Compute Engine API. labels Jun 30, 2022
@codyoss codyoss enabled auto-merge (squash) June 30, 2022 22:41
@codyoss codyoss merged commit eed822d into googleapis:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute/apiv1: TestCapitalLetter failed
2 participants