test(bigquery/storage/managedwriter): address data race #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ironically, the test to do more concurrent things to trigger a specific kind of race condition itself added a new kind of concurrency data race. This switches from using shared variables for checking results to goroutine-local versions.
product-auto-label
bot
added
size: xs
shollyman
requested review from
steffnay
and removed request for
codyoss and
prash-mi
steffnay
approved these changes
Jun 23, 2022
shollyman
added a commit
to shollyman/google-cloud-go
that referenced
this pull request
Jun 23, 2022
Picks up googleapis#6249, a minor fix to testing
shollyman
added a commit
that referenced
this pull request
Jun 23, 2022
Picks up #6249, a minor fix to testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ironically, the test to do more concurrent things to trigger a specific
kind of race condition itself added a new kind of concurrency data race.
This switches from using shared variables for checking results to
goroutine-local versions.
Fixes: #6171