Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): fix iterator distribution bound calculations #6125

Merged
merged 3 commits into from Jun 3, 2022

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Jun 3, 2022

The new method addToDistribution added to support MinExtensionPeriod incorrectly sets the bounds (needed to reverse min/max duration).

Fixes #6123

@hongalex hongalex requested review from a team as code owners June 3, 2022 18:19
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the Pub/Sub API. labels Jun 3, 2022
@hongalex hongalex merged commit 6c470ff into googleapis:main Jun 3, 2022
@hongalex hongalex deleted the fix-pubsub-record-distr branch June 3, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub: maxExtention upper bound is added to the iterator's ack distribution.
2 participants