Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): support bigquery subscriptions #6119

Merged
merged 16 commits into from Jun 22, 2022

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Jun 2, 2022

Add support for bigquery subscriptions, including in the fake

Do not merge until feature is GA

Closes #6118

@hongalex hongalex requested review from a team as code owners June 2, 2022 00:35
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the Pub/Sub API. labels Jun 2, 2022
@@ -210,14 +210,90 @@ func (oidcToken *OIDCToken) toProto() *pb.PushConfig_OidcToken_ {
}
}

// BigQueryConfigState denotes the possible states for a BigQuery Subscription.
type BigQueryConfigState int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added a SubscriptionState field as well as part of this feature. Should we add that here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. I also made the fake return Active for both Subscription/BigQueryConfigState by default.

@hongalex hongalex enabled auto-merge (squash) June 7, 2022 21:02
@hongalex hongalex disabled auto-merge June 7, 2022 21:23
@hongalex hongalex added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 7, 2022
@hongalex hongalex removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 22, 2022
@hongalex hongalex merged commit 81f704a into googleapis:main Jun 22, 2022
@hongalex hongalex deleted the feat-bigquery-config branch June 23, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub: add support for bigquery subscriptions
2 participants