Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: undefined: storage.CommonRequestParams #6055

Closed
RobinUS2 opened this issue May 19, 2022 · 4 comments
Closed

storage: undefined: storage.CommonRequestParams #6055

RobinUS2 opened this issue May 19, 2022 · 4 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@RobinUS2
Copy link

Client

storage

Environment

macOS M1

Go Environment

$ go version
go version go1.18.2 darwin/arm64

$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN="/Users/snip/Documents/gopath/bin"
GOCACHE="/Users/snip/Library/Caches/go-build"
GOENV="/Users/snip/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/snip/Documents/gopath/pkg/mod"
GONOPROXY="github.com/snip"
GONOSUMDB="github.com/snip"
GOOS="darwin"
GOPATH="/Users/snip/Documents/gopath"
GOPRIVATE="github.com/snip"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18.2"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/wm/sqg6cz6s5qn8ht69xr4th9900000gp/T/go-build3589280729=/tmp/go-build -gno-record-gcc-switches -fno-common"

Code

import of package

Expected behavior

package imports

Actual behavior

go: upgraded golang.org/x/sync v0.0.0-20210220032951-036812b2e83c => v0.0.0-20220513210516-0976fa681c29
# cloud.google.com/go/storage
../../../gopath/pkg/mod/cloud.google.com/go/storage@v1.22.0/grpc_client.go:162:7: req.CommonRequestParams undefined (type *"google.golang.org/genproto/googleapis/storage/v2".DeleteBucketRequest has no field or method CommonRequestParams)
../../../gopath/pkg/mod/cloud.google.com/go/storage@v1.22.0/grpc_client.go:162:40: undefined: storage.CommonRequestParams
../../../gopath/pkg/mod/cloud.google.com/go/storage@v1.22.0/grpc_client.go:181:7: req.CommonRequestParams undefined (type *"google.golang.org/genproto/googleapis/storage/v2".GetBucketRequest has no field or method CommonRequestParams)
../../../gopath/pkg/mod/cloud.google.com/go/storage@v1.22.0/grpc_client.go:181:40: undefined: storage.CommonRequestParams
../../../gopath/pkg/mod/cloud.google.com/go/storage@v1.22.0/writer.go:455:24: undefined: storage.CommonRequestParams
../../../gopath/pkg/mod/cloud.google.com/go/storage@v1.22.0/writer.go:457:23: undefined: storage.CommonRequestParams
../../../gopath/pkg/mod/cloud.google.com/go/storage@v1.22.0/writer.go:465:3: unknown field 'CommonRequestParams' in struct literal of type "google.golang.org/genproto/googleapis/storage/v2".StartResumableWriteRequest

Screenshots

Additional context

builds of ~ 1 month ago were just fine

@RobinUS2 RobinUS2 added the triage me I really want to be triaged. label May 19, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label May 19, 2022
@tritone tritone added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels May 19, 2022
@tritone
Copy link
Contributor

tritone commented May 19, 2022

Apologies for the issue. This is due to a breaking change in a dependency which just went through yesterday (similar to #4991).

We will cut a release today that will fix the issue. In the meantime, you can work around by downgrading the go-genproto dependency to an earlier version. google.golang.org/genproto@v0.0.0-20220505152158-f39f71e6c8f3 should work.

FYI @noahdietz

@codyoss
Copy link
Member

codyoss commented May 19, 2022

If you pull in storage v1.22.1 everything should work as expected. Thank you for the report @RobinUS2 and sorry for this disruption. Out of curiosity can you share what version of genproto and storage where in your go.mod when you experienced this issue? Thanks again!

@drakkan
Copy link

drakkan commented May 20, 2022

If you pull in storage v1.22.1 everything should work as expected. Thank you for the report @RobinUS2 and sorry for this disruption. Out of curiosity can you share what version of genproto and storage where in your go.mod when you experienced this issue? Thanks again!

Hi, it happens with these entries in go.mod

cloud.google.com/go/storage v1.22.0
google.golang.org/genproto v0.0.0-20220519153652-3a47de7e79bd // indirect

it works with storage v1.22.1, thanks

@RobinUS2
Copy link
Author

yes it's resolved again, thanks!

bors bot added a commit to pulumi/pulumi that referenced this issue Sep 23, 2022
10835: Update cloud.google.com/go/storage to v1.22.1 r=AaronFriel a=guineveresaenger

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

Upgrade cloud.google.com/go/storage to v1.22.1
I encountered a [bug in a dependency](googleapis/google-cloud-go#6055) while upgrading a provider.
This PR pins to the patch fix version of that dependency explicitly.

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
When upgrading the provider with this version, it works.

<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Guinevere Saenger <guinevere@pulumi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants