Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notebooks): start generating apiv1 #6004

Merged
merged 2 commits into from May 5, 2022

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented May 5, 2022

refs: #5961

@quartzmo quartzmo requested a review from a team as a code owner May 5, 2022 16:43
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: notebooks Issues related to the Vertex AI Workbench API. labels May 5, 2022
@quartzmo quartzmo enabled auto-merge (squash) May 5, 2022 16:49
@codyoss
Copy link
Member

codyoss commented May 5, 2022

@quartzmo Please run go get google.golang.org/genproto@latest to fix compile errors.

@quartzmo
Copy link
Member Author

quartzmo commented May 5, 2022

Thanks, I'll add a genproto fetch to the setup step I run before genbot. (Here's what I did originally for this PR.)

➜  google-cloud-go git:(main) git checkout -b gen-notebooks-v1
Switched to a new branch 'gen-notebooks-v1'
➜  google-cloud-go git:(gen-notebooks-v1) go install github.com/golang/protobuf/protoc-gen-go@v1.5.2 && \
    go install golang.org/x/lint/golint@latest && \
    go install golang.org/x/tools/cmd/goimports@latest && \
    go install honnef.co/go/tools/cmd/staticcheck@latest && \
    go install github.com/googleapis/gapic-generator-go/cmd/protoc-gen-go_gapic@v0.28.0
➜  google-cloud-go git:(gen-notebooks-v1) cd internal/gapicgen
➜  gapicgen git:(gen-notebooks-v1) ✗ go run cloud.google.com/go/internal/gapicgen/cmd/genbot -local -gocloud-dir /Users/chrisdsmith/oss/google-cloud-go -only-gapics -gapic=cloud.google.com/go/notebooks/apiv1

@quartzmo quartzmo merged commit 1084ab1 into googleapis:main May 5, 2022
@release-please release-please bot mentioned this pull request May 5, 2022
@quartzmo quartzmo deleted the gen-notebooks-v1 branch May 5, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: notebooks Issues related to the Vertex AI Workbench API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants