feat(datastore): adds in, not-in, and != query operations #5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
tritone
approved these changes
May 4, 2022
tritone
approved these changes
May 5, 2022
tbpg
suggested changes
May 5, 2022
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
tbpg
approved these changes
May 6, 2022
| // Fields are compared against the provided value using the operator. | ||
| // Multiple filters are AND'ed together. | ||
| // Field names which contain spaces, quote marks, or operator characters | ||
| // should be passed as quoted Go string literals as returned by strconv.Quote | ||
| // or the fmt package's %q verb. | ||
| func (q *Query) Filter(filterStr string, value interface{}) *Query { | ||
| q = q.clone() | ||
| // TODO( #5977 ): Add better string parsing (or something) |
There was a problem hiding this comment.
The comment? The TrimRight() technique of parsing the input filterStr seems like it could introduce unwanted side effects.
telpirion
added a commit
that referenced
this pull request
May 9, 2022
)" This reverts commit db9991f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: adds in, not-in, and != query operations
END_COMMIT_OVERRIDE