feat(spanner/spansql): support DEFAULT keyword #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
neglect-yp
commented
Apr 22, 2022
| @@ -254,6 +265,9 @@ func (cd ColumnDef) SQL() string { | |||
| if cd.NotNull { | |||
| str += " NOT NULL" | |||
| } | |||
| if cd.Default != nil { | |||
There was a problem hiding this comment.
(cd ColumnDef) SQL() generates an invalid SQL like ... DEFAULT (...) AS (...) STORED when both of Default and Generated are not nil. I thought about adding a enum-like const that has Default, Generated or None as a value but I didn't implement that because it will break compatibility.
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
I noticed my mistakes and fixed them. |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
approved these changes
Apr 26, 2022
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #5916
DEFAULTinCREATE TABLEandALTER TABLE ... ADD COLUMNDEFAULTinALTER TABLE ... ALTER COLUMNSET DEFAULTandDROP DEFAULT