Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add support for OLM Prefix/Suffix #5929

Merged
merged 3 commits into from Jun 8, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Apr 21, 2022

Add support for the new LifecycleCondition field options matchesPrefix and matchesSuffix

Tests are not expected to pass until the feature is released

Fixes #5861

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. labels Apr 21, 2022
@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 21, 2022
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label May 22, 2022
@shaffeeullah
Copy link
Contributor

@cojenco these tests should now be passing

@cojenco cojenco removed the stale: old Pull request is old and needs attention. label Jun 3, 2022
@cojenco cojenco marked this pull request as ready for review June 3, 2022 21:02
@cojenco cojenco requested review from a team as code owners June 3, 2022 21:02
@cojenco cojenco requested a review from shaffeeullah June 3, 2022 21:02
@cojenco
Copy link
Contributor Author

cojenco commented Jun 3, 2022

@shaffeeullah tests now pass, sent out for review PTAL when you're available, thanks!

@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jun 4, 2022
Copy link
Contributor

@shaffeeullah shaffeeullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@tritone tritone removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 8, 2022
@cojenco cojenco merged commit ec21d10 into googleapis:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium. stale: old Pull request is old and needs attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: add support for OLM Prefix/Suffix
3 participants