Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixup 1.17 -> 1.18 things #5851

Merged
merged 2 commits into from Apr 5, 2022
Merged

chore: fixup 1.17 -> 1.18 things #5851

merged 2 commits into from Apr 5, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Apr 5, 2022

No description provided.

@codyoss codyoss requested a review from a team as a code owner April 5, 2022 15:07
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 5, 2022
@codyoss
Copy link
Member Author

codyoss commented Apr 5, 2022

It appears we need to rebuild the 1.18 image so that staticcheck has proper support for 1.18

@codyoss codyoss added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Apr 5, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2022
@codyoss codyoss enabled auto-merge (squash) April 5, 2022 16:52
quartzmo
quartzmo approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss merged commit db75317 into googleapis:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codyoss @quartzmo @kokoro-team