Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: start generating bigquery/migration v2 #5848

Merged
merged 7 commits into from Apr 6, 2022

Conversation

shollyman
Copy link
Contributor

I wanted to get generation of the new v2 endpoint for bigquery/migration bootstrapped.

If I need to do more to bootstrap the initial PR, please let me know. I also noticed the fusion link for the genbot run appears to be terminating in failure due to go 1.18 mismatches of some kind.

@shollyman shollyman requested a review from a team as a code owner April 5, 2022 02:43
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 5, 2022
@codyoss
Copy link
Member

codyoss commented Apr 5, 2022

@shollyman I think you will also just want to generate the client locally here too or else it won't generate until there is a generation with this library being updated.

I opened a seperate PR to fix the 1.18 issues you mentioned, thanks for the FYI

@shollyman shollyman requested review from a team and steffnay April 5, 2022 18:35
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Apr 5, 2022
bigquery/go.mod Outdated Show resolved Hide resolved
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Apr 6, 2022
@shollyman shollyman merged commit f923c40 into googleapis:main Apr 6, 2022
@shollyman shollyman deleted the chore-gen-migration branch April 6, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants