Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(internal/gapicgen): exit 0 when regen is in progress #5838

Merged
merged 2 commits into from Apr 5, 2022
Merged

chore(internal/gapicgen): exit 0 when regen is in progress #5838

merged 2 commits into from Apr 5, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Apr 1, 2022

If this methods returns an error a log.Fatal will be called which
is inappropriate for this case.

@codyoss
chore(internal/gapicgen): exit 0 when regen is in progress
a307a15 
If this methods returns an error a log.Fatal will be called which
is inappropriate for this case.
@codyoss codyoss requested a review from quartzmo April 1, 2022 16:03
@codyoss codyoss requested a review from a team as a code owner April 1, 2022 16:03
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 1, 2022
quartzmo
quartzmo approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss enabled auto-merge (squash) April 5, 2022 16:07
@codyoss codyoss merged commit 6b14a3b into googleapis:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codyoss @quartzmo