Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add database roles #5701

Merged
merged 22 commits into from Dec 14, 2022
Merged

feat(spanner): add database roles #5701

merged 22 commits into from Dec 14, 2022

Conversation

varuncnaik
Copy link
Contributor

Adds the ability to specify a database role on requests.

@varuncnaik varuncnaik requested review from a team as code owners February 26, 2022 04:17
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the Spanner API. labels Feb 26, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@ansh0l ansh0l added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 8, 2022
@ansh0l
Copy link
Member

ansh0l commented Mar 8, 2022

Adding do not merge label to avoid accidental merges.

@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Mar 28, 2022
@vi3k6i5 vi3k6i5 requested a review from rahul2393 April 19, 2022 17:22
rahul2393
rahul2393 reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@rahul2393 rahul2393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any reasons why we did not dd the role in BatchCreateSessions requests?

hmehrotra
hmehrotra reviewed Apr 27, 2022
View reviewed changes
Copy link

@hmehrotra hmehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other TODO's

  1. Add tests that use DROP ROLE, REVOKE. (We don't need to test role inheritance, thats sufficiently covered in backend unit tests.

  2. Implement/Add tests for ListDatabaseRoles.

spanner/client.go Show resolved Hide resolved
spanner/client_test.go Outdated Show resolved Hide resolved
spanner/integration_test.go Outdated Show resolved Hide resolved
spanner/integration_test.go Outdated Show resolved Hide resolved
spanner/integration_test.go Show resolved Hide resolved
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Apr 27, 2022
@varuncnaik
Copy link
Contributor Author

any reasons why we did not dd the role in BatchCreateSessions requests?

I did add it, it's part of SessionTemplate.

Add tests that use DROP ROLE, REVOKE.

I added these to TestIntegration_QueryWithRoles and TestIntegration_ReadWithRoles.

I'll work on ListDatabaseRoles soon.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 7, 2022
@varuncnaik varuncnaik force-pushed the cloud-spanner-add-database-roles branch 2 times, most recently from 7cc0651 to 3ada697 Compare June 22, 2022 21:34
@varuncnaik varuncnaik force-pushed the cloud-spanner-add-database-roles branch from bf8dc11 to 1d7195c Compare August 9, 2022 23:58
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@rahul2393 rahul2393 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 16, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2022
@varuncnaik varuncnaik mentioned this pull request Oct 18, 2022
Merged
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@rahul2393 rahul2393 merged commit 6bb95ef into googleapis:main Dec 14, 2022
@release-please release-please bot mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite left review comments

@hmehrotra hmehrotra hmehrotra left review comments

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. size: l Pull request size is large. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@varuncnaik @ansh0l @olavloite @hmehrotra @rahul2393 @kokoro-team