chore(logging): handle TestListLogEntriesRequest flakiness #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
minherz
force-pushed
the
minherz/fix-5441
branch
from
c716a7c
to
6c8a02b
Compare
codyoss
reviewed
Feb 9, 2022
logging/logadmin/logadmin_test.go
Outdated
| } | ||
| filterTime, err := time.Parse(time.RFC3339, strings.Trim(got.Filter[len(timeFilterPrefix):], "\"")) | ||
| if err != nil { | ||
| t.Errorf("%v: expect default filter to have time in RFC3339; got %v", err, got.Filter) |
logging/logadmin/logadmin_test.go
Outdated
|
|
||
| // Default is client's project ID, 24 hour lookback, and no orderBy. | ||
| if !testutil.Equal(got.ResourceNames, []string{"projects/PROJECT_ID"}) || got.OrderBy != "" || timeDiff.Hours() < 24 { | ||
| t.Errorf("expect {\"projects/PROJECT_ID\"} resource names, 24 hour look back filter and native order\ngot %v", got) |
remove timestamp comparison which fails due to (milli-)seconds mismatch when executing time.Now() to get filter time delayed after time.Now() in the test. separately test default (-24h) look back period
align error message with expected format refactor testing params for TestListLogEntriesRequest
minherz
force-pushed
the
minherz/fix-5441
branch
from
0712c55
to
2f54167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove timestamp comparison which fails due to (milli-)seconds mismatch when executing time.Now() to get filter time delayed after time.Now() in the test.
separately test default (-24h) look back period.
Fixes #5441