Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/gapicgen): move breaking change indicator if present #5452

Merged
merged 1 commit into from Feb 4, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Feb 4, 2022

This was discovered processing 8e91ed1.
If a scope is present to be compliant with conventional commits the bang
must be after the scope.

This was discovered processing 8e91ed1.
If a scope is present to be compliant with conventional commits the bang
must be after the scope.
@codyoss codyoss requested a review from a team as a code owner February 4, 2022 18:35
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 4, 2022
@codyoss codyoss enabled auto-merge (squash) February 4, 2022 18:35
@codyoss codyoss merged commit e712df5 into googleapis:main Feb 4, 2022
@codyoss codyoss deleted the bc-indicator branch February 4, 2022 18:55
@release-please release-please bot mentioned this pull request Feb 22, 2022
@release-please release-please bot mentioned this pull request Mar 2, 2022
@release-please release-please bot mentioned this pull request Mar 15, 2022
@release-please release-please bot mentioned this pull request Mar 28, 2022
@release-please release-please bot mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants