fix(storage): update PAP to use inherited instead of unspecified #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
There was a problem hiding this comment.
Let's wait for review from @tritone as well, but looks good to me. Thanks, Brenna!
tritone
reviewed
Oct 5, 2021
| publicAccessPreventionUnspecified = "unspecified" | ||
| publicAccessPreventionEnforced = "enforced" | ||
| // PublicAccessPreventionInherited corresponds to a value of "inherited" | ||
| // and is the default for buckets. |
There was a problem hiding this comment.
@shaffeeullah maybe we should include a sentence about how this means that the value for PAP is inherited from the project, folder, or org? Do we have something like this in other languages?
There was a problem hiding this comment.
i do not believe we have something like that in other languages
tritone
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #4890: does the changes 1 and 2.