New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): returned wrapped error for timeouts #4802
feat(storage): returned wrapped error for timeouts #4802
Conversation
This piggybacks on googleapis#4797 to allow storage to expose wrapped service errors when a call retries without success until timeout or cancellation. I also updated all checks for context sentinel errors in storage to use xerrors.Is instead of strict equality. Users of this package should do the same. I'll update the documentation on errors from this package in a subsequent PR. We will have to bump the dependency on the root module before merging this change I believe. Fixes googleapis#4197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excited about this work!
Fix up type assertions with googleapi.Error to use xerrors.As. In bigquery, this was only required in integration tests and in the package docs. Follows from googleapis#4797 and similar to some of the fixes in storage in googleapis#4802 (storage required additional changes though).
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
facddee
to
c278730
Compare
This piggybacks on #4797 to allow storage to expose wrapped
service errors when a call retries without success until timeout
or cancellation.
I also updated all checks for context sentinel errors in storage
to use xerrors.Is instead of strict equality. Users of this
package should do the same. I'll update the documentation on
errors from this package in a subsequent PR.
We will have to bump the dependency on the root module before
merging this change I believe.
Fixes #4197