Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute/metadata): remove heavy gax dependency #4784

Merged
merged 3 commits into from
Sep 21, 2021
Merged

fix(compute/metadata): remove heavy gax dependency #4784

merged 3 commits into from
Sep 21, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Sep 21, 2021

Because of how the gax package is structured today it ends up
pulling in proto and gRPC which can add a lot of extra deps to the
tree if all you really need is this package.

Fixes: #4783

Because of how the gax package is structured today it ends up
pulling in proto and gRPC which can add a lot of extra deps to the
tree if all you really need is this package.

Fixes: #4783
@codyoss codyoss requested a review from a team as a code owner September 21, 2021 15:24
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Sep 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2021
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Sep 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ea00264 into googleapis:master Sep 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 21, 2021
@codyoss codyoss deleted the reduce-bin-size branch September 21, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute/metadata: binary size increase by 6.5Mb after the commit 81c6039503121f8da3de4f4cd957b8488a3ef620
2 participants