chore(storage): fix gRPC reader size/remain logic #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly sets the size to the size of the whole object and remain to the number of bytes to be read. Adds checks for Size and Remain to the integration tests. I used "chore" because this is still experimental, non-exported code.
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
noahdietz
approved these changes
Aug 23, 2021
noahdietz
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly sets the size to the size of the whole object and
remain to the number of bytes to be read. Adds checks for
Size and Remain to the integration tests.
I used "chore" because this is still experimental, non-exported
code.