Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: carve out sub-modules #4635

Merged
merged 11 commits into from Aug 17, 2021
Merged

chore: carve out sub-modules #4635

merged 11 commits into from Aug 17, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Aug 17, 2021

This commit will be tagged:

  • v0.92.3
  • cloudbuild/v0.1.0
  • monitoring/v0.1.0
  • secretmanager/v0.1.0
  • video/v0.1.0
  • security/v0.1.0
  • gkehub/v0.1.0
  • gkeconnect/v0.1.0
  • area120/v0.1.0
  • analytics/v0.1.0

This commit will be tagged:
	- v0.92.3
	- cloudbuild/v0.1.0
This commit will be tagged:
	- v0.92.3
	- monitoring/v0.1.0
This commit will be tagged:
	- v0.92.3
	- secretmanager/v0.1.0
This commit will be tagged:
	- v0.92.3
	- video/v0.1.0
This commit will be tagged:
	- v0.92.3
	- security/v0.1.0
This commit will be tagged:
	- v0.92.3
	- grafeas/v0.1.0
This commit will be tagged:
	- v0.92.3
	- gkehub/v0.1.0
This commit will be tagged:
	- v0.92.3
	- gkeconnect/v0.1.0
This commit will be tagged:
	- v0.92.3
	- area120/v0.1.0
This commit will be tagged:
	- v0.92.3
	- analytics/v0.1.0
@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 17, 2021
@codyoss codyoss requested a review from a team as a code owner August 17, 2021 20:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@codyoss
Copy link
Member Author

codyoss commented Aug 17, 2021

Command to be run post merge:

git tag v0.92.3 $COMMIT_SHA
git tag cloudbuild/v0.1.0 $COMMIT_SHA
git tag monitoring/v0.1.0 $COMMIT_SHA
git tag secretmanager/v0.1.0 $COMMIT_SHA
git tag video/v0.1.0 $COMMIT_SHA
git tag security/v0.1.0 $COMMIT_SHA
git tag gkehub/v0.1.0 $COMMIT_SHA
git tag gkeconnect/v0.1.0 $COMMIT_SHA
git tag area120/v0.1.0 $COMMIT_SHA
git tag analytics/v0.1.0 $COMMIT_SHA

git push origin refs/tags/v0.92.3
git push origin refs/tags/cloudbuild/v0.1.0
git push origin refs/tags/monitoring/v0.1.0
git push origin refs/tags/secretmanager/v0.1.0
git push origin refs/tags/video/v0.1.0
git push origin refs/tags/security/v0.1.0
git push origin refs/tags/gkehub/v0.1.0
git push origin refs/tags/gkeconnect/v0.1.0
git push origin refs/tags/area120/v0.1.0
git push origin refs/tags/analytics/v0.1.0

@codyoss
Copy link
Member Author

codyoss commented Aug 17, 2021

I am still exploring getting iam and compute split in this PR. But there is currently code in the root module that depends on these libraries which is causing some issues.

@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 17, 2021
@codyoss
Copy link
Member Author

codyoss commented Aug 17, 2021

Going to move forward with these. I think there is a way to still carve out iam and compute but I need to do a little more testing to ensure. After this batch is released though I will reopen the regen pipeline. I don't want to block updates while I am testing things out.

@codyoss codyoss requested review from noahdietz and tbpg August 17, 2021 21:30
@codyoss
Copy link
Member Author

codyoss commented Aug 17, 2021

Failure is expected due to tag not yet existing. Merging.

@codyoss codyoss merged commit 778763f into googleapis:master Aug 17, 2021
@codyoss codyoss deleted the split-phase-3 branch August 17, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants