docs: move example inline into godoc #4626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed, at least temporarily, to facilitate the splitting of modules. The parent module can't depend on a module that is about to be split out as tidying will fail to resolve import paths as the code no longer exists.
google-cla
bot
added
the
cla: yes
tbpg
suggested changes
Aug 16, 2021
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
|
@tbpg I don't think so. Root module needs to be tagged first so that the sub-module can depend on it. Once tagged it can no longer reference the new child mods code without a new dependency on the child mod. I think we should avoid having the root depend on any gapic packages if possible. |
tbpg
approved these changes
Aug 16, 2021
codyoss
added
the
automerge
noahdietz
approved these changes
Aug 16, 2021
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed, at least temporarily, to facilitate the
splitting of modules. The parent module can't depend on a module
that is about to be split out as tidying will fail to resolve
import paths as the code no longer exists.