Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): switch to centralized project autodetect logic #4625

Merged
merged 1 commit into from Aug 16, 2021

Conversation

shollyman
Copy link
Contributor

Switches from a local implementation to the logic in internal/detect.

Switches from a local implementation to the logic in internal/detect.
@shollyman shollyman requested review from codyoss and a team August 16, 2021 19:46
@shollyman shollyman requested a review from a team as a code owner August 16, 2021 19:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Aug 16, 2021
@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Aug 16, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcf-merge-on-green gcf-merge-on-green bot merged commit 18ff070 into googleapis:master Aug 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 16, 2021
@shollyman shollyman deleted the autodetect-switch branch August 16, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants