Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spannertest): Add validation of duplicated column names #4611

Merged
merged 3 commits into from Aug 16, 2021
Merged

feat(spannertest): Add validation of duplicated column names #4611

merged 3 commits into from Aug 16, 2021

Conversation

sryoya
Copy link
Contributor

@sryoya sryoya commented Aug 13, 2021

Fixes #4610

@sryoya sryoya requested review from hengfengli, skuruppu and a team as code owners August 13, 2021 15:00
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2021
@sryoya sryoya changed the title feat(spannertest): add validation for duplicated column names feat(spannertest): Add validation of duplicated column names Aug 13, 2021
@sryoya @olavloite
feat(spannertest): fix error message in validation of duplicated column
5370f21 
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
@sryoya sryoya requested a review from olavloite August 16, 2021 08:00
olavloite
olavloite approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2021
@olavloite olavloite merged commit 84f86a6 into googleapis:master Aug 16, 2021
@sryoya sryoya deleted the add_validation_for_duplicated_columns branch August 16, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spannertest: Add validation of the duplicate column names
4 participants
@sryoya @hengfengli @olavloite @kokoro-team