feat(bigquery/storage/managedwriter): more instrumentation support #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a bytes metric to the list of defined instrumentation metrics, and adds an additional key to track data origin. Ability for users to set the data origin comes a new WithDataOrigin option that can be passed to the managed stream constructor. This also does some minor refactoring of how opencensus view creation is handled.
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bytes metric to the list of defined instrumentation
metrics, and adds an additional key to track data origin. Ability
for users to set the data origin comes a new WithDataOrigin option
that can be passed to the managed stream constructor.
This also does some minor refactoring of how opencensus view creation
is handled.
Towards: #4366