chore(tests): fix google-cloud-sdk-app-engine-go installation in test script #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
codyoss
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
LGTM, again, once these changes settle I think it would be good to move them up to the source image: https://github.com/googleapis/testing-infra-docker/blob/master/go/go116/Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4561. It looks like the GAE test is also failing for a similar reason.
This PR removes the
gcloud components installline to install usingapt-getinstead. It also adds a| catso that the script will continue if installtion fails, in case the package ends up being unnecessary.Note that this impacts the
environment.shtest script only currently used by the logging library.