Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pubsublite): fix flaky TestAssigningSubscriberAddRemovePartitions #4564

Merged
merged 2 commits into from Sep 1, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Aug 6, 2021

Verify that the mock server has received the second expected assignment ack before terminating the test.

Fixes: #4516

@tmdiep tmdiep requested review from a team as code owners August 6, 2021 03:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Aug 6, 2021
@tmdiep tmdiep merged commit d6d4a3c into googleapis:master Sep 1, 2021
@tmdiep tmdiep deleted the flaky_assigning_subs branch September 1, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsublite/internal/wire: TestAssigningSubscriberAddRemovePartitions failed
2 participants