Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): install kubectl using apt-get in test script #4561

Merged
merged 4 commits into from
Aug 10, 2021
Merged

chore(tests): install kubectl using apt-get in test script #4561

merged 4 commits into from
Aug 10, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Aug 5, 2021 •
edited

Our environment tests scripts are currently failing with the error message:

You cannot perform this action because the Cloud SDK component manager 
is disabled for this installation. You can run the following command 
to achieve the same result for this installation:

This PR attempts to fix this by switching installing using curl

@daniel-sanche daniel-sanche requested a review from a team as a code owner August 5, 2021 17:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2021
@simonz130 simonz130 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 10, 2021
codyoss
codyoss approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be nice to move this to our base image so it does not need to be installed everytime.

@daniel-sanche daniel-sanche merged commit 7ed74b8 into master Aug 10, 2021
@daniel-sanche daniel-sanche deleted the fix-kubectl-install branch August 10, 2021 15:55
This was referenced Aug 10, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@simonz130 simonz130 simonz130 approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daniel-sanche @codyoss @simonz130