Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigquery/storage/managedwriter): address flakiness #4546

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

shollyman
Copy link
Contributor

Test was out of sync with comments. Moved the append out of the loop.

Test was out of sync with comments.  Moved the append out of the loop.
@shollyman shollyman requested a review from a team August 2, 2021 21:53
@shollyman shollyman requested a review from a team as a code owner August 2, 2021 21:53
@shollyman shollyman requested a review from tswast August 2, 2021 21:53
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Aug 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss merged commit 653b82b into googleapis:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants