Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery/storage/managedwriter): naming and doc improvements #4508

Merged
merged 8 commits into from Jul 28, 2021

Conversation

shollyman
Copy link
Contributor

Minor changes:

WithTracePrefix -> WithTraceID for the option and accompanying downstream usage
exported TableParentFromStreamName to aid users of BatchCommit.

The rest of the PR represents docstring improvements.

Towards #4366

@shollyman shollyman requested a review from a team as a code owner July 28, 2021 19:16
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jul 28, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2021
@shollyman shollyman requested a review from codyoss July 28, 2021 19:18
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Jul 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 663c899 into googleapis:master Jul 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 28, 2021
@shollyman shollyman deleted the fr-managedwriter-docs branch July 28, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants