Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigquery/storage/managedwriter): test all stream types #4507

Merged
merged 4 commits into from Jul 28, 2021

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Jul 28, 2021

This PR adds testing to support all stream types, and refactors the
integration test to support parallel testing and reduce some of the
boilerplate code.

Towards #4366

This PR adds testing to support all stream types, and refactors the
integration test to support parallel testing and reduce some of the
boilerplate code.
@shollyman shollyman requested a review from a team as a code owner July 28, 2021 17:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jul 28, 2021
@shollyman shollyman requested a review from codyoss July 28, 2021 17:26
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couples that you can choose to do if you want.

bigquery/storage/managedwriter/integration_test.go Outdated Show resolved Hide resolved
@shollyman shollyman merged commit d8ec92b into googleapis:master Jul 28, 2021
@shollyman shollyman deleted the fr-managedclient-moretesting branch July 28, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants