fix(bigquery/storage/managedwriter): fix double-close error, add tests #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing tests picked up the error, so hooray.
shollyman
added
the
do not merge
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
codyoss
requested changes
Jul 27, 2021
| if err != nil { | ||
| t.Errorf("couldn't get stream info: %v", err) | ||
| } | ||
| log.Printf("info id: %s type: %s", info.GetName(), info.GetType().String()) |
There was a problem hiding this comment.
If you want to log here I would recommend t.Log
There was a problem hiding this comment.
Sorry, this (and the other comment) was due to some debugging I was doing, which exposed the need to backend whitelist some functionality. Cleared it out.
shollyman
removed
the
do not merge
codyoss
approved these changes
Jul 28, 2021
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing tests picked up the error, so hooray.
BufferedStream integration test exposed that while the API surface is in preview without special requirements, advanced features such as the FlushRows rpc used by BufferedStream does. This has been whitelisted for test projects, but we'll want to add this to doc.go when I start that PR.
Towards #4366