chore: manually regen cloudbuild do to breaking changes #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to manually manipulate the old code directory so that it could compile. In the future this makes me question if v2 directories make sense for generated code were we must always match the proto spec for code to actually work. I also include a few changes to the generator the helped me regen and debug what was wrong. Changes: feat(cloudbuild/apiv1): Implementation of Build Failure Info: - Added message FailureInfo field PiperOrigin-RevId: 385847244 Source-Link: googleapis/googleapis@f84d1e2 feat(cloudbuild/apiv1): add a WorkerPools API BREAKING CHANGE: Proto had a prior definitions of WorkerPool resources which were never supported. This change replaces those resources with definitions that are currently supported. Committer: @mwiczer PiperOrigin-RevId: 385610622 Source-Link: googleapis/googleapis@7a1fb83
google-cla
bot
added
the
cla: yes
|
@broady I am starting to doubt that v2 directories make sense for generated proto sources for reasons like this. |
noahdietz
reviewed
Jul 21, 2021
…-go into cloudbuild-breaking
|
It's a bummer because we made the |
|
@noahdietz It is not the same as it is missing a handful of RPCs as of right now, but it could be. But yeah I think the v2 pattern for generated clients might not make sense after seeing all of the trouble it causes. |
|
The kokoro failures are due to the breaking changes in this API which are expected as they fix the code to return the proper types that the API exposes. Force pushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to manually manipulate the old code directory so that it
could compile. In the future this makes me question if v2 directories
make sense for generated code were we must always match the proto
spec for code to actually work.
I also include a few changes to the generator the helped me regen
and debug what was wrong.
Changes:
feat(cloudbuild/apiv1): Implementation of Build Failure Info: - Added message FailureInfo field
PiperOrigin-RevId: 385847244
Source-Link: googleapis/googleapis@f84d1e2
feat(cloudbuild/apiv1): add a WorkerPools API
BREAKING CHANGE: Proto had a prior definitions of WorkerPool resources which were never supported. This change replaces those resources with definitions that are currently supported.
Committer: @mwiczer
PiperOrigin-RevId: 385610622
Source-Link: googleapis/googleapis@7a1fb83