Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub/pstest): add ability to create a pstest server listening on a specified port #4459

Merged
merged 1 commit into from Jul 19, 2021

Conversation

caod123
Copy link
Contributor

@caod123 caod123 commented Jul 19, 2021

In some of our tests we handle port allocations manually and would prefer to pass in an allocated port for our pstest Server dependency rather than having the pstest.NewServer call allocate an available port.

@caod123 caod123 requested review from a team as code owners July 19, 2021 19:40
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jul 19, 2021
@google-cla
Copy link

google-cla bot commented Jul 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 19, 2021
@caod123
Copy link
Contributor Author

caod123 commented Jul 19, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 19, 2021
@hongalex hongalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2021
@caod123 caod123 requested a review from hongalex July 19, 2021 20:22
Copy link
Member

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

@hongalex hongalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2021
a specified port

Signed-off-by: Danny Cao <caoxiaohua@gmail.com>
@hongalex hongalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2021
@dc185333
Copy link

Rebased on master, may need to force-run kokoro again

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2021
@hongalex hongalex merged commit f1b7c8b into googleapis:master Jul 19, 2021
@hongalex
Copy link
Member

Thanks for the fix @dc185333, merged.

gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants