Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable): emulator crashes in SampleRowKeys #4455

Conversation

coryan
Copy link
Member

@coryan coryan commented Jul 18, 2021

This is a second race condition in SampleRowKeys. As SampleRowKeys
iterates over the rows it needs to grab a lock before using the row, as
the contents of the row may be changed by another thread.

Fixes #2600 (again).

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 18, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2021
@coryan
Copy link
Member Author

coryan commented Jul 18, 2021

/cc: @dbolduc FYI.

@coryan coryan marked this pull request as ready for review July 18, 2021 19:08
@coryan coryan requested review from crwilcox, kolea2, tritone and a team as code owners July 18, 2021 19:08
@coryan
Copy link
Member Author

coryan commented Jul 18, 2021

The Kokoro failure seems unrelated to this change (see #4450 for a likely culprit, and thanks to @dbolduc for saving me time in researching the CI failure).

@crwilcox
Copy link
Contributor

rerunning CI. Test that failed is in Spanner, may be unrelated.

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2021
This is a second race condition in SampleRowKeys. As SampleRowKeys
iterates over the rows it needs to grab a lock before using the row, as
the contents of the row may be changed by another thread.
@coryan coryan force-pushed the fix-bigtable-emulator-sample-row-keys-synchronization branch from b743e25 to 9d0ab3b Compare July 19, 2021 18:02
@coryan
Copy link
Member Author

coryan commented Jul 19, 2021

Rebased, to pick the #4450 changes and hopefully fix CI.

@coryan
Copy link
Member Author

coryan commented Jul 19, 2021

@crwilcox can you give Kokoro a nudge? I may have messed things up with my rebase.

@crwilcox crwilcox added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 19, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2021
@crwilcox crwilcox merged commit 691e923 into googleapis:master Jul 19, 2021
@coryan coryan deleted the fix-bigtable-emulator-sample-row-keys-synchronization branch July 19, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigtable: emulator crashes with concurrent operations
3 participants