Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(spanner): fix errors not reporting when emulator test passes #4451

Merged
merged 2 commits into from Jul 16, 2021
Merged

test(spanner): fix errors not reporting when emulator test passes #4451

merged 2 commits into from Jul 16, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jul 16, 2021

Emulator tests were overwritting the results of the main test
run which can cause errors that occured in main test run not
to be reported when the emulator tests pass. Now emulator tests
append to the test log.

Updates: #4450

@codyoss
test(spanner): fix errors not reporting when emulator test passes
7ac2427 
Emulator tests were overwritting the results of the main test
run which can cause errors that occured in main test run not
to be reported when the emulator tests pass. Now emulator tests
append to the test log.

Updates: #4450
@codyoss codyoss requested review from hengfengli, skuruppu and a team as code owners July 16, 2021 16:41
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jul 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2021
@codyoss codyoss requested a review from olavloite July 16, 2021 16:41
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jul 16, 2021
olavloite
olavloite approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this so quickly. The fact that the build is failing, is a good sign in this case, as the failure is caused by a known failure that was previously missed because the build turned green even though the test failed.

@codyoss
Copy link
Member Author

codyoss commented Jul 16, 2021

I will force merge this and let that test be fixed in another PR.

@codyoss codyoss merged commit 8f3275c into googleapis:master Jul 16, 2021
@codyoss codyoss deleted the spanner-test-fix branch July 16, 2021 17:14
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@hengfengli hengfengli Awaiting requested review from hengfengli

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codyoss @olavloite