New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(spanner): fix the failed TestColumnTypeErr test #4450
test(spanner): fix the failed TestColumnTypeErr test #4450
Conversation
@olavloite I wonder why the previous CI tests did not catch this error. It may be due to caching the test results. |
Yes, that is very strange. I looked into the log of the build for the PR, and the test failed in that build as well, but the build is marked as green: https://source.cloud.google.com/results/invocations/1e012eba-5a8c-4681-9a59-919f7ec7e1d3/targets/cloud-devrel%2Fclient-libraries%2Fgo%2Fgoogle-cloud-go%2Fpresubmit%2Fgo111/log (search for |
@hengfengli If you take a look at the Kokoro build log for this build as well, you will see that there is a test failure there as well:
@codyoss Is this a known issue? We are getting green builds from kokoro while there are test failures. |
@olavloite It is the whitespaces between |
@hengfengli It's caused by this line which will add an additional space based on a deterministically random boolean value. So you could call |
@olavloite Thanks for bringing this to my attention this is a bug I was unaware of. Will try to get out a fix today. |
) Emulator tests were overwritting the results of the main test run which can cause errors that occured in main test run not to be reported when the emulator tests pass. Now emulator tests append to the test log. Updates: #4450
@olavloite "google.golang.org/protobuf/internal/detrand" is an internal package. I can't use it in my code. I did it in a different way, PTAL. |
Sorry, I didn't notice that it was an internal package. Your alternative solution looks good to me. |
@skuruppu Can I get an approval from you? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging this to fix CI. |
Fix #4443