test(spanner): fix the failed TestColumnTypeErr test

[hengfengli]

Fix #4443

[hengfengli]

@olavloite I wonder why the previous CI tests did not catch this error. It may be due to caching the test results.

[olavloite]

@olavloite I wonder why the previous CI tests did not catch this error. It may be due to caching the test results.

Yes, that is very strange. I looked into the log of the build for the PR, and the test failed in that build as well, but the build is marked as green: https://source.cloud.google.com/results/invocations/1e012eba-5a8c-4681-9a59-919f7ec7e1d3/targets/cloud-devrel%2Fclient-libraries%2Fgo%2Fgoogle-cloud-go%2Fpresubmit%2Fgo111/log (search for TestColumnTypeErr in the log output).
It worries me that the CI can mark a build as green while there are test failures. Do you know who could best look into that?

[olavloite]

@hengfengli If you take a look at the Kokoro build log for this build as well, you will see that there is a test failure there as well:

=== RUN   TestRowToString
--- FAIL: TestRowToString (0.00s)
    row_test.go:1693: got {fields: [name:"F1"  type:{code:STRING} name:"F2"  type:{code:STRING}], values: [string_value:"v1" string_value:"v2"]}, want {fields: [name:"F1" type:{code:STRING} name:"F2" type:{code:STRING}], values: [string_value:"v1" string_value:"v2"]}

@codyoss Is this a known issue? We are getting green builds from kokoro while there are test failures.

[hengfengli]

@hengfengli If you take a look at the Kokoro build log for this build as well, you will see that there is a test failure there as well:

=== RUN   TestRowToString
--- FAIL: TestRowToString (0.00s)
    row_test.go:1693: got {fields: [name:"F1"  type:{code:STRING} name:"F2"  type:{code:STRING}], values: [string_value:"v1" string_value:"v2"]}, want {fields: [name:"F1" type:{code:STRING} name:"F2" type:{code:STRING}], values: [string_value:"v1" string_value:"v2"]}

@olavloite It is the whitespaces between name and type. Sometime, it gets two spaces and sometimes it gets a single space. I tested it locally and the test passes. Do you have any suggestion on how to verify this? Or, maybe I can just delete this test.

[olavloite]

@hengfengli If you take a look at the Kokoro build log for this build as well, you will see that there is a test failure there as well:

=== RUN   TestRowToString
--- FAIL: TestRowToString (0.00s)
    row_test.go:1693: got {fields: [name:"F1"  type:{code:STRING} name:"F2"  type:{code:STRING}], values: [string_value:"v1" string_value:"v2"]}, want {fields: [name:"F1" type:{code:STRING} name:"F2" type:{code:STRING}], values: [string_value:"v1" string_value:"v2"]}

@olavloite It is the whitespaces between name and type. Sometime, it gets two spaces and sometimes it gets a single space. I tested it locally and the test passes. Do you have any suggestion on how to verify this? Or, maybe I can just delete this test.

@hengfengli It's caused by this line which will add an additional space based on a deterministically random boolean value. So you could call if detrand.Bool() in the test to determine whether the string will/should contain 2 spaces or not.

[codyoss]

@olavloite Thanks for bringing this to my attention this is a bug I was unaware of. Will try to get out a fix today.

[hengfengli]

if detrand.Bool()

@olavloite "google.golang.org/protobuf/internal/detrand" is an internal package. I can't use it in my code. I did it in a different way, PTAL.

[olavloite]

if detrand.Bool()

@olavloite "google.golang.org/protobuf/internal/detrand" is an internal package. I can't use it in my code. I did it in a different way, PTAL.

Sorry, I didn't notice that it was an internal package. Your alternative solution looks good to me.

[hengfengli]

@skuruppu Can I get an approval from you? Thanks.

[codyoss]

LGTM

[codyoss]

Merging this to fix CI.