New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal/godocfx): set exit code, print cmd output, no go get ... #4445

Merged

tbpg merged 1 commit into master from godocfx

Jul 15, 2021

Contributor

tbpg commented Jul 15, 2021

The command was failing, but the job was succeeding. These changes:

Fix the underlying issue (...).
Print cmd output to make debugging easier.
Set an exit code.


          fix(internal/godocfx): set exit code, no ...

d48e347

tbpg requested a review from codyoss

July 15, 2021 13:37

tbpg requested a review from a team as a code owner

July 15, 2021 13:37

google-cla bot added the cla: yes label

codyoss approved these changes

View reviewed changes

Member

codyoss left a comment

LGTM, thanks!

tbpg merged commit cc70f77 into master

tbpg deleted the godocfx branch

July 15, 2021 15:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment