Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add row.String() and refine error message for decoding a struct array #4431

Merged
merged 4 commits into from Jul 15, 2021
Merged

feat(spanner): add row.String() and refine error message for decoding a struct array #4431

merged 4 commits into from Jul 15, 2021

Conversation

hengfengli
Copy link
Contributor

Two changes:

  • Add row.String()
  • Refine the error message for decoding a struct array

@hengfengli hengfengli added the api: spanner Issues related to the Spanner API. label Jul 14, 2021
@hengfengli hengfengli self-assigned this Jul 14, 2021
@hengfengli hengfengli requested review from skuruppu and a team as code owners July 14, 2021 04:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2021
olavloite
olavloite approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the commit message should start with feat instead of fix. This is not really a bug that is being fixed, but a feature that was missing that is being added.

@hengfengli hengfengli changed the title fix(spanner): add row.String() and refine error message for decoding a struct array feat(spanner): add row.String() and refine error message for decoding a struct array Jul 14, 2021
@hengfengli
Copy link
Contributor Author

@skuruppu Can I get an approval from you?

@hengfengli hengfengli merged commit f6258a4 into googleapis:master Jul 15, 2021
@hengfengli hengfengli deleted the refine-row-to-struct branch July 15, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuruppu skuruppu skuruppu approved these changes

@olavloite olavloite olavloite approved these changes

Assignees

@hengfengli hengfengli

Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hengfengli @skuruppu @olavloite