Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): retry all goaway errors #4384

Merged
merged 3 commits into from Jul 7, 2021
Merged

fix(pubsub): retry all goaway errors #4384

merged 3 commits into from Jul 7, 2021

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Jul 7, 2021

The previous iteration of this PR, #4313, only retried GOAWAY in conjunction with an EOF string, which doesn't capture all GOAWAY errors. Now, all error messages with GOAWAY and error code UNKNOWN are retried.

Fixes #4257

@hongalex hongalex requested review from a team as code owners July 7, 2021 18:45
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jul 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2021
codyoss
codyoss approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongalex hongalex added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1eae86f into googleapis:master Jul 7, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 7, 2021
@hongalex hongalex deleted the pubsub-goaway branch July 8, 2021 01:01
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 8, 2021
@yoshi-code-bot
chore: release pubsub 1.12.2 (#4387)
c68eda0 
🤖 I have created a release \*beep\* \*boop\*
---
### [1.12.2](https://www.github.com/googleapis/google-cloud-go/compare/pubsub/v1.12.1...pubsub/v1.12.2) (2021-07-08)


### Bug Fixes

* **pubsub:** retry all goaway errors ([#4384](https://www.github.com/googleapis/google-cloud-go/issues/4384)) ([1eae86f](https://www.github.com/googleapis/google-cloud-go/commit/1eae86f1882660d901b9fb0e8dab6f138a048dbb)), refs [#4257](https://www.github.com/googleapis/google-cloud-go/issues/4257)

This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: non-retryable rpc errors in subscription Receive() method
3 participants
@hongalex @codyoss @kokoro-team