Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute: fix bugs in alpha release #4380

Closed
3 tasks done
noahdietz opened this issue Jul 7, 2021 · 11 comments
Closed
3 tasks done

compute: fix bugs in alpha release #4380

noahdietz opened this issue Jul 7, 2021 · 11 comments
Assignees
@noahdietz
Labels
api: compute Issues related to the Compute Engine API. type: process A process-related concern. May include testing, release, or the like.

Comments

@noahdietz
Copy link
Contributor

noahdietz commented Jul 7, 2021 •
edited

The compute/apiv1 alpha release in v0.86.0 has a few known bugs. They are as follows:

  • missing scheme on default endpoint
  • GET/DELETE requests are generated with a body
  • remove EmitUnpopulated encoding option

First discovered post-release and then reported in #4377 by users.

This is a tracking bug.
@noahdietz noahdietz added the type: process A process-related concern. May include testing, release, or the like. label Jul 7, 2021
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Jul 7, 2021
@noahdietz noahdietz self-assigned this Jul 7, 2021
@noahdietz noahdietz mentioned this issue Jul 7, 2021
Closed
@noahdietz
Copy link
Contributor Author

googleapis/gapic-generator-go#698 fixes the missing scheme.

@noahdietz
Copy link
Contributor Author

googleapis/gapic-generator-go#699 fixes the extraneous request body.

@noahdietz
Copy link
Contributor Author

Regeneration of compute/apiv1 with the above fixes passes CI: #4364.

@codyoss codyoss closed this as completed Jul 7, 2021
@codyoss codyoss reopened this Jul 7, 2021
@noahdietz
Copy link
Contributor Author

Local integration tests succeed.

@noahdietz
Copy link
Contributor Author

Fixes carried in https://github.com/googleapis/gapic-generator-go/releases/tag/v0.21.6.

@noahdietz noahdietz mentioned this issue Jul 7, 2021
Merged
codyoss pushed a commit that referenced this issue Jul 7, 2021
@noahdietz
chore(internal): update microgen to v0.21.6 (#4382)
0a2ba11 
Carries changes necessary for #4380.

Regen staged at #4364.
@noahdietz
Copy link
Contributor Author

Changes carried in #4383

@noahdietz
Copy link
Contributor Author

To fix the third issue, need googleapis/gapic-generator-go#702

@noahdietz
Copy link
Contributor Author

Released generator fix in https://github.com/googleapis/gapic-generator-go/releases/tag/v0.21.7

@noahdietz noahdietz mentioned this issue Jul 7, 2021
Merged
codyoss pushed a commit that referenced this issue Jul 7, 2021
@noahdietz
chore(intenral): update microgen to v0.21.7 (#4388)
6235a8a 
Carries fix for EmitUnpopulated issue in #4380
@codyoss codyoss mentioned this issue Jul 8, 2021
Merged
@noahdietz
Copy link
Contributor Author

Pending the outcome of some more testing before making a new release. Should have an update today midday PST.

@noahdietz
Copy link
Contributor Author

Integration tests uncovered another issue, which was fixed with googleapis/gapic-generator-go#710. Updating generator version in #4425.

@noahdietz noahdietz mentioned this issue Jul 13, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 13, 2021
@noahdietz
fix(compute): properly generate PUT requests (#4426)
a7491a5 
Changes regenerated locally with generator v0.21.8.

This is the fix for #4380 (comment).
@noahdietz
Copy link
Contributor Author

All mentioned bugs were fixed in the release: https://github.com/googleapis/google-cloud-go/releases/tag/v0.87.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
api: compute Issues related to the Compute Engine API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codyoss @noahdietz