chore(internal/gapicgen): gen googleapis-discovery compute gapic #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Needs #4306 merged as well. |
|
Need #4315 to go in first |
|
We will need another gapic-generator-go release as there things being fixed before we can start generating compute |
|
generator v0.21.2 introduced in #4315 should do the trick |
noahdietz
added
the
do not merge
|
Holding off the merge until #4315 is in. |
noahdietz
removed
the
do not merge
noahdietz
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds generation of a
computegapic that uses googleapis-discovery.Note: we need to capture some fixes in gapic-generator-go with a release there and update here before this will work.
cc: @software-dov @vchudnov-g