Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spanner): trigger a release for low cost instance #4264

Merged
merged 3 commits into from Jun 18, 2021
Merged

chore(spanner): trigger a release for low cost instance #4264

merged 3 commits into from Jun 18, 2021

Conversation

hengfengli
Copy link
Contributor

@hengfengli hengfengli commented Jun 15, 2021 •
edited

Release-As: 1.21.0

Trigger release for low cost instance.

@hengfengli hengfengli added the api: spanner Issues related to the Spanner API. label Jun 15, 2021
@hengfengli hengfengli requested a review from codyoss June 15, 2021 00:15
@hengfengli hengfengli self-assigned this Jun 15, 2021
@hengfengli hengfengli requested review from skuruppu and a team as code owners June 15, 2021 00:15
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2021
@hengfengli
Copy link
Contributor Author

@codyoss Can this trigger a new release? Or should I do something like #4002?

@codyoss
Copy link
Member

codyoss commented Jun 15, 2021

@hengfengli You will need to make sure the Release-As: 1.XX.0 shows up in the merged commit. Chores do not trigger releases otherwiese -- just feats and fixes.

@hengfengli hengfengli added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 16, 2021
@hengfengli
Copy link
Contributor Author

Please do not merge at the moment. I am waiting for an approval from the backend team.

@hengfengli hengfengli removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 17, 2021
@hengfengli
Copy link
Contributor Author

@codyoss Can you approve this PR? Thanks.

@hengfengli hengfengli merged commit 24c4451 into googleapis:master Jun 18, 2021
@hengfengli hengfengli deleted the lci-release branch June 18, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees

@hengfengli hengfengli

Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hengfengli @codyoss