New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logging)!: increase DefaultEntryByteThreshold to 8Mb #4247
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
@loburm mind sanity checking this? I think changing default thresholds may produce unforeseen results, so we might want to release this with preview |
In overall it looks good to me. |
@codyoss can I get your pointers, this PR is marked as a breaking change in go116 because:
It's technically not since we're increasing the threshold, not decreasing it. How do I override this, or fix this test? Thank you! |
It is a breaking change. I silly example is if someone wrote a test validate its value, or grabbed an element of an array at this index, which could panic if the array was not large enough. That being said I with proper usage I think this is probably fine ... @tbpg would you agree? To get around this check the commit message needs to be formatted in a special manner: google-cloud-go/internal/apidiff/apidiff.go Lines 223 to 238 in 00140bd
Also, the subsequent release would need to be manual overridden as it will propose a v2. |
Fixes: #3823
DefaultEntryByteThreshold =
1 << 20 // 1MiB
===>1 << 23 // 8MiB
since size of an entries.write request can be up to 10 MB.DefaultBufferedByteLimit
is unchanged as that's more a cap on memory utilization.