Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): truncate name of instance to be under 30 chars #4180

Merged
merged 3 commits into from
May 27, 2021

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented May 27, 2021

fixes #4175, which reported attempts to create over the limit of bt instance naming.

improves #4174 by printing the fields we are comparing.

@crwilcox crwilcox requested review from kolea2, tritone and a team as code owners May 27, 2021 15:55
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crwilcox crwilcox merged commit 72474ea into googleapis:master May 27, 2021
@crwilcox crwilcox deleted the fix-bt-flakes branch May 27, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigtable: TestIntegration_AdminBackup failed
2 participants