Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(spanner): fix test case using reflection #4169

Merged
merged 1 commit into from
May 25, 2021

Conversation

olavloite
Copy link
Contributor

The refactoring of the generated gapic client had broken a test case that used reflection to get an internal value. This fixes the test
by first getting the (new) internalClient, and then getting the value from the internal client.

Fixes #4156

The refactoring of the generated gapic client had broken a test case
that used reflection to get an internal value. This fixes the test
by first getting the (new) internalClient, and then getting the value
from the internal client.

Fixes #4156
@olavloite olavloite requested a review from hengfengli May 25, 2021 05:27
@olavloite olavloite requested review from skuruppu and a team as code owners May 25, 2021 05:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 25, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label May 25, 2021
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hengfengli hengfengli merged commit 8bd87cb into master May 25, 2021
@hengfengli hengfengli deleted the spanner-fix-session-client-test branch May 25, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: many tests failed
2 participants