Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): run against live endpoint for continuous tests #4159

Merged
merged 12 commits into from
May 26, 2021

Conversation

crwilcox
Copy link
Contributor

Fixes #4158 (target live service for continuous tests) and #4157 (cleanup)

@crwilcox crwilcox requested review from kolea2, tritone and a team as code owners May 24, 2021 21:18
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2021
@crwilcox
Copy link
Contributor Author

Manual continuous run is green 🥳

Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome!

Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements, thanks!

os.Exit(exit)
}

func cleanup(c IntegrationTestConfig) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding this.

bigtable/integration_test.go Outdated Show resolved Hide resolved
bigtable/integration_test.go Show resolved Hide resolved
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple small nits

bigtable/integration_test.go Outdated Show resolved Hide resolved
bigtable/integration_test.go Outdated Show resolved Hide resolved
@crwilcox crwilcox merged commit 66c1176 into googleapis:master May 26, 2021
@crwilcox crwilcox deleted the continuous-tests branch October 29, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigtable: run tests against live bigtable for continuous test runs
4 participants