Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigquery): add integration test for Column ACLs #3895

Merged
merged 2 commits into from Apr 7, 2021

Conversation

shollyman
Copy link
Contributor

Now that we have a v1 PolicyTagManager client, we can test the policy tag integration
with column ACLs.

This also plumbed in a new PTM client as part of the integration testing
setup, much like we make a cloud storage client available.

Now that we have a v1 PTM client, we can test the policy tag integration
with column ACLs.

This also plumbed in a new client as part of the integration testing
setup, much like we make a cloud storage client available.
@shollyman shollyman requested a review from a team as a code owner April 6, 2021 21:32
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Apr 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2021
@shollyman shollyman requested a review from tswast April 6, 2021 21:35
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I assume we aren't trying to test the actual Column ACLs query logic because that's not a client responsibility?

bigquery/integration_test.go Show resolved Hide resolved
bigquery/integration_test.go Show resolved Hide resolved
@shollyman
Copy link
Contributor Author

Looks good! I assume we aren't trying to test the actual Column ACLs query logic because that's not a client responsibility?

Yup. We're not the right place for this level of e2e enforcement validation.

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss changed the title testing(bigquery): add integration test for Column ACLs test(bigquery): add integration test for Column ACLs Apr 7, 2021
@shollyman shollyman merged commit 733c72a into googleapis:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants